Conversation
VladIftime
requested review from
Flix6x and
lfse-slafleur
and removed request for
lfse-slafleur
Flix6x
previously requested changes
Jan 8, 2025
Collaborator
Flix6x
left a comment
Flix6x
left a comment
There was a problem hiding this comment.
Thanks. Besides a leftover breakpoint I only have a minor suggestion to refactor.
lfse-slafleur
approved these changes
Jan 10, 2025
Member
lfse-slafleur
left a comment
lfse-slafleur
left a comment
There was a problem hiding this comment.
Once requested changes of @Flix6x are resolved, this is approved.
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate tests only if they dont exists